Skip to content

Conversation

@albertvillanova
Copy link
Member

@albertvillanova albertvillanova commented Sep 26, 2022

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Sep 26, 2022

The documentation is not available anymore as the PR was closed or merged.

@albertvillanova albertvillanova added the dataset contribution Contribution to a dataset script label Sep 26, 2022
Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - have you re-run the datasets-cli test command to update num_examples per config ?

@albertvillanova
Copy link
Member Author

Thanks @lhoestq, I had missed that...

@albertvillanova albertvillanova merged commit 5eefb56 into huggingface:main Sep 26, 2022
@albertvillanova albertvillanova deleted the fix-5017 branch September 26, 2022 10:57
@thesofakillers
Copy link

thx for the super fast work @albertvillanova ! any estimate for when the relevant release will happen?

Thanks again

@albertvillanova
Copy link
Member Author

albertvillanova commented Sep 26, 2022

@thesofakillers after a recent change in our library (see #4059), now fixes in all datasets are immediately accessible. You can try it:

french = datasets.load_dataset("xcsr", "X-CSQA-fr")

Please note there is an additional fix to that dataset in progress (to be merged today):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dataset contribution Contribution to a dataset script

Projects

None yet

Development

Successfully merging this pull request may close these issues.

xcsr: X-CSQA simply uses english for all alleged non-english data

4 participants